-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default fonts are vertically offset on some Linux distributions #1170
Comments
I'm seeing this in Chrome 64 on Fedora 26 where the default monospace font is DejaVu Sans Mono, but not in Firefox 58 on the same platform using the same font. |
+1 on Fedora 25. This bug do invisible symbol "_" |
Automatic merge from submit-queue. Bump kubernetes-container-terminal to v3.0.0 Requires kubernetes-ui/container-terminal#35 ![screen shot 2018-02-23 at 10 37 13 am](https://user-images.githubusercontent.com/895728/36602271-99eb8a40-1885-11e8-91d1-a5e63c4fd55b.PNG) ![screen shot 2018-02-23 at 10 37 38 am](https://user-images.githubusercontent.com/895728/36602273-99f55296-1885-11e8-8e27-927979047c9b.PNG) Known issues: * [Default fonts are vertically offset on some Linux distributions](xtermjs/xterm.js#1170) ![screen shot 2018-02-23 at 9 32 32 am](https://user-images.githubusercontent.com/895728/36599221-bf750902-187c-11e8-8f3f-becafbcbb46b.PNG) * Firefox on Windows incorrectly calculates the terminal width due to padding on div.terminal.xterm ![screen shot 2018-02-23 at 9 33 56 am](https://user-images.githubusercontent.com/895728/36599319-0d1b7aba-187d-11e8-9705-4956454e92ac.PNG)
@AndrienkoAleksandr the underscore thing is probably happening due to #1138 This issue is about some fonts on Linux seems to not be drawing in the right spot. |
This now affects Ubuntu 18.04 as well. |
- Also fixes actually using Roboto-Mono, xterm.js now only accepts fontFamily customization via the JS api. (uses `<canvas`). - There is an issue (xtermjs/xterm.js#1170) if linux has to fall back to 'monospace' where things fail to render correctly, so provide a couple of common options so this rarely happens. - If we distribute robo-mono in the webpack bundle that might also work.
- Also fixes actually using Roboto-Mono, xterm.js now only accepts fontFamily customization via the JS api. (uses `<canvas`). - There is an issue (xtermjs/xterm.js#1170) if linux has to fall back to 'monospace' where things fail to render correctly, so provide a couple of common options so this rarely happens. - If we distribute robo-mono in the webpack bundle that might also work.
- Also fixes actually using Roboto-Mono, xterm.js now only accepts fontFamily customization via the JS api. (uses `<canvas`). - There is an issue (xtermjs/xterm.js#1170) if linux has to fall back to 'monospace' where things fail to render correctly, so provide a couple of common options so this rarely happens. - If we distribute robo-mono in the webpack bundle that might also work.
- Also fixes actually using Roboto-Mono, xterm.js now only accepts fontFamily customization via the JS api. (uses `<canvas`). - There is an issue (xtermjs/xterm.js#1170) if linux has to fall back to 'monospace' where things fail to render correctly, so provide a couple of common options so this rarely happens. - If we distribute robo-mono in the webpack bundle that might also work.
Do we have any ideas for a temporary fix? Just running into this issue with Ubuntu and electron. (update) for those with this issue i just changed the font family to find one that worked. Ubuntu mono seemed to do the job for me. |
Another workaround: changing the font size (from 14 -> 13, default font) fixed the issue for me in vscode. |
Changing fontFamily (to Ubuntu mono, for instance) does not fix, but makes the issue less evident: try to print two vertical extended bars
or run some command that displays them (mc) and look at the gaps in vertical lines |
I'm havingthis problem on linux, but changing the font to 'Ubuntu mono' worked for me |
This issue was closed off as it's fixed in the experimental WebGL renderer addon. It's not ready yet but I'm closing this off so I don't forget about it. See this query for current webgl addon issues https://github.com/xtermjs/xterm.js/issues?q=is%3Aissue+is%3Aopen+label%3Aarea%2Faddon%2Fwebgl |
VS Code issue: microsoft/vscode#36322
Getting around this will probably involve drawing a character and checking the pixels to see where it was drawn in the cell and adjusting as necessary. From what I can see this just happens on some fonts which happen to be default on Kali and Debian.
The text was updated successfully, but these errors were encountered: