Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ST sequence, fix emacs #3704

Merged
merged 10 commits into from
Mar 23, 2022
Merged

add ST sequence, fix emacs #3704

merged 10 commits into from
Mar 23, 2022

Conversation

meganrogge
Copy link
Member

@meganrogge meganrogge commented Mar 23, 2022 •
edited
Loading

fixes #3700

emacs.mov

@meganrogge meganrogge self-assigned this Mar 23, 2022
@meganrogge meganrogge requested a review from Tyriar March 23, 2022 15:49
@jerch
Copy link
Member

jerch commented Mar 23, 2022

@meganrogge Your ST got somewhat scrambled, and it is already defined C1 (further down). But I suggest not to use the naked 8-bit value, as some encodings will screw things up with 8bit. It should be safe to use the ESC notation instead (which is ESC \ for ST).

@meganrogge meganrogge requested a review from jerch March 23, 2022 16:56
@meganrogge meganrogge added this to the 4.19.0 milestone Mar 23, 2022
Tyriar
Tyriar requested changes Mar 23, 2022
View reviewed changes
src/browser/Terminal.ts Outdated Show resolved Hide resolved
jerch
jerch approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@jerch jerch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (tests still need to be adjusted)

jerch
jerch reviewed Mar 23, 2022
View reviewed changes
test/api/InputHandler.api.ts Outdated Show resolved Hide resolved
meganrogge and others added 2 commits March 23, 2022 15:43
@meganrogge
Revert "fix most of tests"
79c990d 
This reverts commit becab08.
@meganrogge @jerch
fix tests
f6a384b 
Co-authored-by: jerch <[email protected]>
@meganrogge meganrogge enabled auto-merge March 23, 2022 21:40
@meganrogge meganrogge merged commit d57329f into xtermjs:master Mar 23, 2022
This was referenced Jul 2, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerch jerch jerch approved these changes

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
4.19.0
Development

Successfully merging this pull request may close these issues.

Emacs xterm specific initialization does not complete properly
3 participants
@meganrogge @jerch @Tyriar