Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required eslint and eslint-plugin-jsdoc versions #4930

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

PerBothner
Copy link
Contributor

@PerBothner PerBothner commented Dec 30, 2023

This fixes a problem when using node 20.x.x, because [email protected] requires node version "^14 || ^16 || ^17 || ^18 || ^19".

$ node --version
v20.10.0
$ yarn
yarn install v1.22.10
[1/4] Resolving packages...
[2/4] Fetching packages...
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
error [email protected]: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "20.10.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

This fixes a problem when using node 20.*.*, because [email protected]
requires node version "^14 || ^16 || ^17 || ^18 || ^19".
@Tyriar Tyriar added this to the 5.4.0 milestone Dec 30, 2023
@Tyriar Tyriar merged commit b97baa7 into xtermjs:master Dec 30, 2023
16 checks passed
@PerBothner PerBothner deleted the update-eslint branch December 30, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants