Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] Upgrade Gulp, TypeDoc using NPM #213

Merged
merged 2 commits into from
Apr 10, 2024
Merged

[BREAKING CHANGE] Upgrade Gulp, TypeDoc using NPM #213

merged 2 commits into from
Apr 10, 2024

Conversation

crutchcorn
Copy link
Contributor

Using NPM instead of Yarn, this PR:

  • Upgrades Gulp to 5
  • Upgrades TypeDoc to 0.25
  • Configures TypeDoc to use a TSConfig file and non-built in TypeScript version, to match compat updates
  • Hotpatches (using patch-package) this PR in to support the new TypeDoc version: feat!: support TypeDoc 0.25+ rogierschouten/gulp-typedoc#60
  • Generates the new docs using the new TypeDoc version

This is marked as a breaking change, seeing as the upgrades to TypeDoc and such have seemingly changed the contents and URL structure of the site in some minor ways

Whew - this is a big PR. Apologies for the diff here!

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Tyriar Tyriar merged commit 3272e9c into xtermjs:master Apr 10, 2024
@Tyriar Tyriar self-assigned this Apr 10, 2024
@crutchcorn crutchcorn deleted the upgrade-gulp-npm branch April 11, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants