Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function DeleteSlicer #30

Merged
merged 3 commits into from
Sep 28, 2024
Merged

New function DeleteSlicer #30

merged 3 commits into from
Sep 28, 2024

Conversation

centurion-hub
Copy link
Contributor

PR Details

Add new function DeleteSlicer

Description

  • Add new function DeleteSlicer
  • Add unit test for DeleteSlicer
  • Update documentation

Related Issue

none

Motivation and Context

Add new function DeleteSlicer

How Has This Been Tested

Add new unit test. Both new unit test and existed one have passed.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.82%. Comparing base (63cc7c2) to head (fdb5006).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files           1        1           
  Lines        2631     2643   +12     
=======================================
+ Hits         2600     2612   +12     
  Misses         21       21           
  Partials       10       10           
Flag Coverage Δ
unittests 98.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 7ee4da1 into xuri:main Sep 28, 2024
3 checks passed
@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants