Declaration of Carbon\Carbon::setTime($hour, $minute, $second = 0) should be compatible with DateTime::setTime($hour, $minute, $second = NULL, $microseconds = NULL)

[ocean90]

PHP 7.1 changes how Datetime handles microseconds, see http://php.net/manual/de/migration71.incompatible.php#migration71.incompatible.datetime-microseconds.

Looks like this also affects DateTime::setTime()which now has a $microseconds parameter.

[mikeyzm]

Update Carbon library to latest version may solve this problem.

[Danny-Guzman]

Carbon::setTime($hour, $minute, $second = NULL) not compatible with
PHP 7.1.0 DateTime::setTime($hour, $minute, $second = null, $microseconds = NULL )

http://php.net/manual/en/datetime.settime.php
7.1.0 The microseconds parameter was added.

On line 681 of the includes/lib/Carbon.php the function setTime is missing the $microseconds = null parameter

[ahmed-sigmalux]

Any luck getting your PR committed?

[Danny-Guzman]

Negative it always seems to fail the continuous integration, for now I've just manually made the edits that I needed

…

On Tue, Nov 7, 2017 at 10:31 AM, Ahmed Khalil ***@***.***> wrote: Any luck getting your PR committed? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#914 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXMXyd-N5Zpy1Dg1gHVWY5xj_QOZ4mBIks5s0KIJgaJpZM4MoKrh> .

[cfoellmann]

@Danny-Guzman I think the test WP_Stream\Test_Admin::test_ajax_filters is broken by something in the current codebase. Nothing to do with any PR now pending.
maybe someone from the @xwp devs can have a look. ping @lukecarbis

[proweb]

+1
PHP 7.1

[robertandrews]

I just switched from PHP 5.6 to 7.2 and found this warning...

Warning: Declaration of Carbon\Carbon::setTime($hour, $minute, $second = 0) should be compatible with DateTime::setTime($hour, $minute, $second = NULL, $microseconds = NULL) in /home/mysite/public_html/wp-content/plugins/stream/includes/lib/Carbon.php on line 2213

The same issue also affects the Date Range Filter plugin you worked on.

Any chance of a resolution?

[DavidCramer]

Addressed via 4017b31 and #966