Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing alert highlight color in list table #1246

Merged
merged 1 commit into from
May 11, 2021

Conversation

ocean90
Copy link
Contributor

@ocean90 ocean90 commented Mar 29, 2021

Fixes #1245.

$record is a plain PHP object which has no meta property. This PR converts it to a proper Record as done in Alert_Type_Highlight::action_link_remove_highlight().

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix missing alert highlight colors in list table

Copy link
Contributor

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you @ocean90!

@kidunot89 Can you please review and approve this?

@kasparsd kasparsd merged commit 88b0f3c into xwp:develop May 11, 2021
@ocean90 ocean90 deleted the fix/alert-highlight-color branch May 12, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerts: Highlight background color isn't used in list table
2 participants