Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Fix PHP Type error #1475

Merged
merged 1 commit into from
Jun 17, 2024
Merged

CLI: Fix PHP Type error #1475

merged 1 commit into from
Jun 17, 2024

Conversation

Soean
Copy link
Contributor

@Soean Soean commented Jan 12, 2024 •
edited by delawski
Loading

A record is an Object, not an Array, so we should use property_exists() instead array_key_exists.

Fixes #1474, #1437.

Release Changelog

  • Fix: PHP Uncaught TypeError in CLI command #1474

roborourke
roborourke approved these changes May 15, 2024
View reviewed changes
Copy link

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$record is expected to be an object judging by the line below, approving.

@roborourke
Copy link

Hey @kasparsd, the CLI query command is completely broken right now because of this. Will be great to get a patch release out asap if possible.

If you're open to adding some more maintainers I'd be happy to help in that regard from the Human Made side.

kasparsd
kasparsd approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@kasparsd kasparsd merged commit 87610e2 into xwp:develop Jun 17, 2024
1 check passed
@Soean Soean deleted the 1474 branch June 18, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roborourke roborourke roborourke approved these changes

@kasparsd kasparsd kasparsd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: PHP Uncaught TypeError
3 participants
@Soean @roborourke @kasparsd