Adds Playwright, first tests and linting. #1529
Conversation
This runs in your local database and is noisy! I'd rather run it with a separate database but that might be overkill, I don't know.
There was a problem hiding this comment.
@tharsheblows Looks great so far!
I think we could use this setup to run E2E tests locally for now and not worry about the CI integration at this point. If you think that's a good approach, we just need to make sure test:e2e is not run in GitHub action.
There was a problem hiding this comment.
📝 note: @tharsheblows Let's also make sure .distignore is kept up to date.
There was a problem hiding this comment.
Thank you! Ack, this is one of the reason I love code reviews, I completely forgot about that.
This renames tests/tests to tests/phpunit for clarity.
|
@delawski I've updated this to not run the e2e tests in the GH action by renaming it and added the files to |
# Conflicts: # package-lock.json # package.json
|
@tharsheblows I'm sorry about the dependencies update train when you were trying to merge it to I resolved the conflicts now and will merge as soon as the CI checks are complete. |
Fixes #1528.
This runs in your local database and is noisy! I'd rather run it with a separate database but that might be overkill, I don't know. Currently it causes the lint action to fail as there's not the executables installed.