-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Grunt with wp-scripts
#1541
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a60da22
Add `wp-scripts` package and initial webpack config
delawski 7cf3b36
Enqueue `admin.js` in a new way
delawski 10b3ae2
Include alerts list stylesheet in build workflow
delawski 68886ee
Add dev task for watching files and building right away
delawski 853e35e
Abstract away scripts and styles enqueueing logic
delawski deb1f73
Enqueue admin-exclude in new way
delawski afb67c4
Enqueue global.js in new way and clean up other scripts
delawski 25ca12e
Move assets enqueue logic to central `plugin` class
delawski ce802c0
Use new way of enqueueing for alerts and settings
delawski 6f2ae87
Use new way of enqueueing for Yoast connector asset
delawski c645802
Use new way of enqueueing for alert type highlight assets
delawski ee62d36
Remove Grunt with its dependencies
delawski fdb0ed3
Use JS linter from wp-scripts
delawski 0c3240e
Auto-format JS files, fix other lint issues manually
delawski 3ba4faa
Use the same tooling for E2E tests linting
delawski af8a059
Run Playwright tests via wp-scripts
delawski 9d3d628
Ensure test-related files are ignored
delawski 46f4105
Make `select2` and `jquery.timeago` npm dependencies
delawski c2aea51
Make `datepicker` styles a SCSS partial
delawski 5f4fdcd
Use entire horizontal space in alerts table
delawski 5671225
Use SVGs instead of custom font; reorg assets
delawski 8862878
Fix unit tests
delawski ee6ff4a
Fix lint issues
delawski 0dcadfd
Update docs
delawski 04a1a1e
Build assets before linting and testing
delawski 5939594
Merge branch 'refs/heads/develop' into feature/1502-remove-grunt
delawski 2fbee97
Merge branch 'refs/heads/develop' into feature/1502-remove-grunt
delawski 9530765
Merge branch 'refs/heads/develop' into feature/1502-remove-grunt
delawski 5e4acf1
Deprecate constant instead of removing it
delawski 79b2879
Lint before building assets so that it fails early
delawski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
/ui/lib/ | ||
**/*.min.js | ||
/vendor/ | ||
/node_modules/ | ||
/build/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
module.exports = { | ||
extends: [ | ||
'plugin:@wordpress/eslint-plugin/recommended-with-formatting', | ||
], | ||
env: { | ||
browser: true, | ||
es6: true, | ||
}, | ||
rules: { | ||
'@wordpress/no-global-event-listener': 'off', | ||
'jsdoc/check-indentation': 'error', | ||
'@wordpress/dependency-group': 'error', | ||
'import/order': [ 'error', { groups: [ 'builtin', [ 'external', 'unknown' ], 'internal', 'parent', 'sibling', 'index' ] } ], | ||
'jsdoc/require-param': 'off', | ||
'jsdoc/require-param-type': 'off', | ||
'jsdoc/check-param-names': 'off', | ||
}, | ||
}; |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
File renamed without changes
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥜 nitpick
I think that just in case someone is dequeueing this for whatever reason that we should keep the constant or deprecate it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must have missed it – definitely can be removed now :)I'm sorry, I got it all wrong. You've got a valid point. Since we're not planning to release a major version anytime soon, it'd be wise to deprecate this constant instead of removing it. I'll add it back with a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 5e4acf1.