Use WC_Order_Factory to get order id

[marcinkrzeminski]

Fixes #1655

Describe your approach and how it fixes the issue.

Checklist

• Project documentation has been updated to reflect the changes in this pull request, if applicable.
• I have tested the changes in the local development environment (see contributing.md).
• I have added phpunit tests.

Release Changelog

• Fix: Use preferred WC_Order_Factory to get the order ID

[tharsheblows]

There's another occurrence of this in the post status transition hook here -- should that one be updated also?

[tharsheblows]

❓question
I'm not sure on this -- WC_Order_Factory::get_order_id() will always return the post ID:

        /**
	 * Get the order ID depending on what was passed.
	 *
	 * @since 3.0.0
	 * @param  mixed $order Order data to convert to an ID.
	 * @return int|bool false on failure
	 */
	public static function get_order_id( $order ) {
		if ( false === $order ) {
			return self::get_global_order_id();
		} elseif ( is_numeric( $order ) ) {
			return $order;
		} elseif ( $order instanceof WC_Abstract_Order ) {
			return $order->get_id();
		} elseif ( ! empty( $order->ID ) ) {
			return $order->ID;
		} else {
			return false;
		}
	}

Is that the order ID now?

Although -- this is on the deleted_post hook so it should be ok?

[marcinkrzeminski]

@tharsheblows good question, however I agree that we should be OK since this action is triggered on post deletion.

While I was working on a solution, I came across this comment on the abstract-wc-order.php, and that's why I used it.

* Get the order if ID is passed, otherwise the order is new and empty.
* This class should NOT be instantiated, but the wc_get_order function or new WC_Order_Factory
* should be used. It is possible, but the aforementioned are preferred and are the only
* methods that will be maintained going forward.

[tharsheblows]

@marcinkrzeminski Ah ha, thanks!

[marcinkrzeminski]

There's another occurrence of this in the post status transition hook here -- should that one be updated also?

Good catch. I've found another place and updated it as well to use the \WC_Order_Factory::get_order_id()

[tharsheblows]

@marcinkrzeminski Ah ha, thanks!

[tharsheblows]

👏 praise
Nice catch!