Select2 Upgrade/Exclude List #855
Conversation
Removes the helper row when submitting. Currently removes logic that gets rid of empty rows which will need to be re-added.
|
Some issues I've found:
|
| return $output; | ||
| } | ||
|
|
||
| public function render_as_table() { |
There was a problem hiding this comment.
Rename to render_fields_table()
Change render_all to render_fields Change render_as_table to render_fields_table Consolidate render_field wp_parse_args calls Rename prepare_data_string to prepare_data_attributes_string Add documentation
|
@lukecarbis There were a couple incongruencies that I was unable to figure out.
After monitoring the
Looking at the exclude page, I do not see the problems you are talking about. See below:
I'll be looking to see if there is a way to reproduce the problems you're finding. |
This makes it simpler to grab a top level item and its children, as the ID always contains the top level item. This doesn’t work for ‘Sites’ as the ID for sites is actually blogs.
Removes clearAll button due to CSS issues.
Processing prevents multiple values
… bugfix/issue-852
|
In regards to the |
|
In regards to the Top level items should be bold, Indents, instead of dashes… This occurs in the filters on the Stream screen. |
|
@Chacha Please review all the code, and test. This should now fix everything. |
|
@lukecarbis Looks great. |
Moves towards using
<select>boxes in the entire exclude interface.@lukecarbis Please give feedback on any bugs you see.
See #852