Support proxy mode by checking the X-Forwarded-For header first
#963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidCramer
suggested changes
Apr 3, 2018
| @@ -107,6 +107,10 @@ function( $var ) { | |||
| $role = ''; | |||
| } | |||
|
|
|||
| // Support proxy mode by checking the `X-Forwarded-For` header first | |||
| $ip_address = wp_stream_filter_input( INPUT_SERVER, 'HTTP_X_FORWARDED_FOR', FILTER_VALIDATE_IP ); | |||
| $ip_address = $ip_address ? $ip_address : wp_stream_filter_input( INPUT_SERVER, 'REMOTE_ADDR', FILTER_VALIDATE_IP ); | |||
There was a problem hiding this comment.
@fjarrett This is cool, thanks. The REMOTE_ADDR is also requested on line 154/158 So will need to be applied there.
Perhaps it might be better to have method to fetch the IP, or even a simpleIP param set in the constructor to prevent code duplication.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lukecarbis When in reverse proxy mode, the
REMOTE_ADDRvalue will always show the IP of the proxy server (ATS, Varnish, HAProxy, etc). Most proxies will pass along the real client IP via theX-Forwarded-Forheader. If it exists, Stream should prefer that as the real IP and only useREMOTE_ADDRas a fallback.👋 It's been a while 😃