updated yrs bindings to use version 0.17.2 #35
Conversation
| @@ -16,7 +16,7 @@ unsafe impl Sync for YrsDoc {} | |||
| impl YrsDoc { | |||
| pub(crate) fn new() -> Self { | |||
| let mut options = Options::default(); | |||
| options.offset_kind = OffsetKind::Utf32; | |||
| options.offset_kind = OffsetKind::Utf16; | |||
There was a problem hiding this comment.
We dropped support for Utf32, as it's wasn't used and it's not really useful. If Swift is using proper unicode, there are code points even longer than 4 bytes.
|
The tuist stuff (what @nugmanoff originally set up to build Xcode projects for the examples) look to have bit-rotted as tuist evolved since we last updated and touched this, which is what's causing an issue with CI. I'll look into it more and see what I can sort out there (it's not something I'm deeply familiar with)... I'm not having much luck directly, so I reached out to get help. This was previously working, so I'm not 100% clear on how it's evolved or what's changed to make it broken now: tuist/tuist#5671 |
|
I guess I am late to the party. Just noticed the notifications. @heckj looks like you've succeeded with updating the Tuist syntax to the latest version – nice catch! Let me know if I can assist more |
This PR updates yrs dependency to version 0.17.2.