Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple table readers #15

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

egorchakov
Copy link
Contributor

  • add support for multiple table readers
  • add a protobuf -> pl.DataFrame mcap decoder factory
  • replace CarlaRecordsTableBuilder with JsonTableReader

@sandhawalia
Copy link
Contributor

LGTM. Maybe we overlooked, after adding support for video decoding (CPU/GPU), we didn't add a sample dataset config which uses video CPU / GPU decoder. Both yaak.yaml/carla.yaml have DirectoryFrameReader.

Does it make sense to add atleast one of these ? Or convert one of the existing one to use HW accelerated video decoding ?

examples/config_templates/dataset/yaak.gpu.yaml
examples/config_templates/dataset/carla.gpu.yaml

@egorchakov
Copy link
Contributor Author

@sandhawalia

Maybe we overlooked, after adding support for video decoding (CPU/GPU), we didn't add a sample dataset config which uses video CPU / GPU decoder. Both yaak.yaml/carla.yaml have DirectoryFrameReader.

will address once we move examples to notebooks

@egorchakov egorchakov merged commit 5e99824 into main Oct 21, 2024
1 check passed
@egorchakov egorchakov deleted the feat/table-readers branch October 21, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants