feat: Zenseact Open Dataset (zod) support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorchakov
force-pushed
the
feat/zod
branch
2 times, most recently
from
34f22d4 to
d6d7f76
Compare
sandhawalia
reviewed
Nov 10, 2024
sandhawalia
reviewed
Nov 10, 2024
sandhawalia
reviewed
Nov 10, 2024
sandhawalia
reviewed
Nov 10, 2024
sandhawalia
reviewed
Nov 10, 2024
There was a problem hiding this comment.
Need to check if we have permissions for this
sandhawalia
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Nothing glaring that stood out expcept.
- Gonna check on ZOD license we can add them to a public repo
- Some clarification around
SourcevsReadersuffix
egorchakov
force-pushed
the
feat/zod
branch
2 times, most recently
from
32145eb to
1957ce6
Compare
- add zod (https://zod.zenseact.com/) - refactor TableAligner - flatten batch structure - more generic table processing: mapping -> pytree - group sources/readers by filetype - remove scripts/build_table.py + configs - test data fixes
egorchakov
added a commit
that referenced
this pull request
Nov 20, 2024
- add zod (https://zod.zenseact.com/) - refactor TableAligner - flatten batch structure - more generic table processing: mapping -> pytree - group sources/readers by filetype - remove `scripts/build_table.py` + configs - test data fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts/build_table.py+ configs