msauth: improvement for token cache store handling #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
yaegashi
commented
Jun 27, 2020
yaegashi
commented
- Fix bug that fails to save a refreshed token in DeviceAuthorizationGrant()
- Token cache dirty state control, save cache to file only when it's updated
- Network location support for token cache store (Azure Blob Storage URL with SAS assumed)
- CacheKey(): new function - Manager - Dirty: cache dirty state - GetToken/PutToken(): new methods (Cache method is removed) - LoadFile()/SaveFile(): load/save with dirty state control - DeviceAuthorizationGrant(): save updated token correctly
- ReadLocation()/WriteLocation(): new functions - Manager - LoadFile()/SaveFile()/SaveFileAlways(): updated
yaegashi
force-pushed
the
msauth-token-cache
branch
from
d0a4b82 to
aeb63b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.