Merge pull request rails#53261 from zachasme/deferrable-special-chars…

…-dumping

Allow deferrable foreign key on column with non-ascii characters

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Fix parsing of SQLite foreign key names when they contain non-ASCII characters
+
+    *Zacharias Knudsen*
+
 *   Fix parsing of MySQL 8.0.16+ CHECK constraints when they contain new lines.
 
     *Steve Hill*

activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb

@@ -407,7 +407,7 @@ def add_reference(table_name, ref_name, **options) # :nodoc:
       end
       alias :add_belongs_to :add_reference
 
-      FK_REGEX = /.*FOREIGN KEY\s+\("(\w+)"\)\s+REFERENCES\s+"(\w+)"\s+\("(\w+)"\)/
+      FK_REGEX = /.*FOREIGN KEY\s+\("([^"]+)"\)\s+REFERENCES\s+"(\w+)"\s+\("(\w+)"\)/
       DEFERRABLE_REGEX = /DEFERRABLE INITIALLY (\w+)/
       def foreign_keys(table_name)
         # SQLite returns 1 row for each column of composite foreign keys.

activerecord/test/cases/migration/foreign_key_test.rb

@@ -601,6 +601,14 @@ def test_schema_dumping_with_defferable_initially_immediate
 
             assert_match %r{\s+add_foreign_key "astronauts", "rockets", deferrable: :immediate$}, output
           end
+
+          def test_schema_dumping_with_special_chars_deferrable
+            @connection.add_reference :astronauts, :røcket, foreign_key: { to_table: :rockets, deferrable: :deferred }
+
+            output = dump_table_schema "astronauts"
+
+            assert_match %r{\s+add_foreign_key "astronauts", "rockets", column: "røcket_id", deferrable: :deferred$}, output
+          end
         end
 
         def test_does_not_create_foreign_keys_when_bypassed_by_config