This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
add keepalive option #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
CLA is valid! |
|
Already aggreed, please check again. |
|
I like the idea, but the "keepalive" name is confusing to me. Squid (an HTTP proxy) calls this "stale while revalidate" though that's too long for us here :) Perhaps "useStale" instead? |
tangxinfa
force-pushed
the
feature-keepalive
branch
from
ebb9706 to
601ed48
Compare
tangxinfa
force-pushed
the
feature-keepalive
branch
from
601ed48 to
21ea7a7
Compare
parallel call dns methods for speedup test.
drewfish
reviewed
Dec 19, 2016
| } | ||
| } catch (e) { | ||
| if (staleCallback) { | ||
| staleCallback(); |
There was a problem hiding this comment.
This seems to be saying "if an exception is thrown mark the cache entry as not stale", does that make sense?
|
It might be worthwhile to mention the useStale callback in the "advanced caching" section in README.md. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
ttl, if cached item expired bykeepalive, it return the cached value, and make asynchronously dns request for update the cache.