Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace not found issue #51

Merged
merged 2 commits into from
May 13, 2018
Merged

Fix namespace not found issue #51

merged 2 commits into from
May 13, 2018

Conversation

roderickhsiao
Copy link
Contributor

@roderickhsiao roderickhsiao commented May 10, 2018 •
edited
Loading

@redonkulus we expose the whole object instead of namespace 😢

@coveralls
Copy link

coveralls commented May 10, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 98.936% when pulling eaab956 on roderickhsiao:globalVars into 6286ac4 on yahoo:master.

@redonkulus
Copy link
Collaborator

You can do this release

@roderickhsiao
Copy link
Contributor Author

roderickhsiao commented May 10, 2018 via email

@roderickhsiao
Copy link
Contributor Author

@redonkulus published 2.0.1

we can merge this PR

@redonkulus redonkulus merged commit 00d0f84 into yahoo:master May 13, 2018
@roderickhsiao roderickhsiao deleted the globalVars branch May 14, 2018 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redonkulus redonkulus redonkulus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roderickhsiao @coveralls @redonkulus @tinder-rhsiao