On load, create timezone-aware datetime objects if possible #113
Conversation
On loading data, if timestamps have an ISO "+HH:MM" UTC offset then the resultant datetime is converted to UTC. This change adds that timezone information to the datetime objects. Importantly, this addresses a Django warning (and potential error) that appears when using both YAML fixtures in a timezone-aware project. It was raised as a Django issue (https://code.djangoproject.com/ticket/18867), but subsequently closed because the Django devs felt that this is a PyYAML problem.
|
Build fails on python 2.6 due to dropped support by Python team (I think? Not sure how to interpret the logs exactly). I don't think this is an error in the pull request. |
|
Thanks, glad to help! |
|
Hey any movement on this? From what I can see in the CI output, I don't think python 2.6 is ever going to pass - and all the other tests pass. |
|
I think this makes sense. |
|
Looking at the implementation, the timezone is always set to UTC, with the actual datetime being shifted. That seems wrong; if we're going to parse the datetime, we ought to take the values as intended. |
|
Is there an ETA on supporting TZ date times. Currently 163, 113 and 251 are all open which try to resolve this issue. It seems to be an issue being faced by a lot of people and the fact 3 pull requests are open for such an issue highlights this. It would be good if someone from the core team could shed some light on why these changes have taken a while to get reviewed so we may assist where possible; whether it is that the devs are busy or have reservations about the PR's. In either case, it would be good to start a conversation around this so we can all contribute to help push this change into master (sooner rather than later). Cross-posting to other tickets. |
|
I think I'll close this one as it only changes lib3. #163 seems like the one we should merge. |
On loading data, if timestamps have an ISO "+HH:MM" UTC offset then the resultant datetime is currently converted to UTC. This change creates a timezone-aware datetime when this happens. If there is no offset, a naive datetime is created as per the previous version.
Importantly, this addresses a Django warning (and potential error) that appears when using YAML fixtures in a timezone-aware project. It was raised as a Django issue (https://code.djangoproject.com/ticket/18867), but subsequently closed because the Django devs felt that this is a PyYAML problem.