Use setuptools in setup.py for setup() function #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the modern, recommended approach as documented at: https://docs.python.org/3/library/distutils.html#module-distutils > Most Python users will not want to use this module directly, but > instead use the cross-version tools maintained by the Python Packaging > Authority. In particular, setuptools is an enhanced alternative to > distutils that provides: ... Fixes warning: "Unknown distribution option: 'python_requires'" and more importantly, the python_requires will now be honored as that is a setuptools only feature. Allows removing the bdist_wheel command as this is available by default.
4383
approved these changes
Oct 30, 2018
webknjaz
approved these changes
Nov 4, 2018
|
Any reluctance on merging this? It's a pretty straightforward change. |
|
Note that this change still keeps the |
|
I remember having some trouble doing exactly this a year or so ago, but I was never able to figure out what the actual problem was. It had something to do with the setuptools |
|
@nitzmahone so let's merge it then |
|
(Especially in the light of the recent changes: pypa/setuptools#2228 + pypa/setuptools#2230) |
|
handled in #407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the modern, recommended approach as documented at:
https://docs.python.org/3/library/distutils.html#module-distutils
Fixes warning: "Unknown distribution option: 'python_requires'" and more
importantly, the
python_requireswill now be honored as that is asetuptools only feature.
Allows removing the bdist_wheel command as this is available by default.