Fix the concurrency issues in removeObjectsOneByOne
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes classic golang for-loop variable capturing issue that leeds to incorrect results in goroutines. This is fixed in latest versions of golang, but this project uses go 1.15, so it won't work as expected by an author.
Previous implementation didn't have any synchronization mechanism for goroutines that does the work. There are multiple approaches to make it work correctly, let's start with the simplest - atomics.
I guess this is pretty reasonable to have the working queue with the same size as the maximum number of workers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR fixes some obvious concurrency issues in function that tries to remove objects asynchronously:
I had experienced some troubles with tests (minio server build failed, go 1.15 toolkit doesn't have
cmd.Environ()) that is completely unrelated with my changes and as soon as I fixed it, everything worked fine.