Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm shrinkwrap file. #3854

Closed
wants to merge 1 commit into from
Closed

Add npm shrinkwrap file. #3854

wants to merge 1 commit into from

Conversation

theiawolfe
Copy link

@theiawolfe theiawolfe commented Jul 7, 2017

Since most people and many CIs do the initial install of yarn by
running npm install yarn, please include the npm shrinkwrap file.

Summary
Adds the file 'npm-shrinkwrap.json'

This will prevent issues such as #3850 when installing yarn via npm, as suggested in #3853

Since most people and many CIs do the initial install of yarn by
running `npm install yarn`, please include the npm shrinkwrap file.
@jiripospisil
Copy link

Be aware of this however npm/npm#17185.

@arcanis
Copy link
Member

arcanis commented Jul 7, 2017

Hey, thanks for this PR! However, I'm not sure this is the right way to solve this issue. We should ideally publish the single-file releases, which wouldn't be affected by any dependency issue.

@arcanis arcanis self-assigned this Jul 7, 2017
@bestander
Copy link
Member

I agree with @arcanis.
Yarn is not ready to maintain the shrinkwrap file in its repo because all developers are using Yarn for development.
As @arcanis described to avoid subdependencies breaking Yarn it is better to introduce a prepublish script that would bundle yarn.js and publish only this file.

I'll close this PR but looking forward for a PR with the prepublish script 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants