fix(config): Use boolifyWithDefault() for bools from environment #4823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change will decrease the build size from 9.94 MB to 9.94 MB, a decrease of 912 bytes (0%)
|
BYK
approved these changes
Nov 2, 2017
BYK
changed the title
calvinhuang
pushed a commit
to calvinhuang/yarn
that referenced
this pull request
Nov 9, 2017
…npkg#4823) **Summary** Use `boolifyWithDefault()` to determine if environment variable values are `true` or `false`. This ensures that all environment variables interpret the same values the same way. This changes the behavior of `YARN_SILENT` and `YARN_IGNORE_PATH` if they have "unexpected" values, all nonempty stings beside `"0"` and `"false"` are now interpreted as `true`. For example `YARN_SILENT=hello` was interpreted as `false` before, now it is `true`. This makes some sense since those values are truthy in Javascript, but generally makes things more predictable if it works like that for all yarn environment variables. `YARN_SILENT=true` was also interpreted as `false`. This now definitely makes more sense since it will be interpreted as `true`. See also [yarnpkg#4811](yarnpkg#4811 (comment)). **Test plan** There should be no change to the existing intended functionality and the existing tests still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
boolifyWithDefault()to determine if environment variable values aretrueorfalse. This ensures that all environment variables interpret the same values the same way.This changes the behavior of
YARN_SILENTandYARN_IGNORE_PATHif they have "unexpected" values, all nonempty stings beside"0"and"false"are now interpreted astrue. For exampleYARN_SILENT=hellowas interpreted asfalsebefore, now it istrue. This makes some sense since those values are truthy in Javascript, but generally makes things more predictable if it works like that for all yarn environment variables.YARN_SILENT=truewas also interpreted asfalse. This now definitely makes more sense since it will be interpreted astrue.See also #4811.
Test plan
There should be no change to the existing intended functionality and the existing tests still pass.