do not remove pattern from lockfile if it is overridden by resolution #5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arcanis
reviewed
Mar 26, 2018
| expect(lockfile.indexOf('foobar')).toBeGreaterThanOrEqual(0); | ||
| }, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Can you rather test that we correctly bailout (ie install with resolution settings should correctly bailout during the integrity check)?
This was referenced Mar 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr addresses issue #5250 and #4778 . Currently if package.json contains resolutions, pattern which is overriden by resolution will be removed from lockfile, which causing integrity-check fail and as following new lockfile being generated. So i just removed code which deletes the pattern and since resolutions test are passing i assuming that part of code should not be there or some test cases are missing. Issue #4778 was fixed with #4793, so i reverted the code from that pr.
Test plan
Added a new test case in resolutions which will fail in a current master.