-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency validate-npm-package-license to ^3.0.3 #5626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the lockfile is not updated properly (see the install
job's build failure logs). If you can update it I'd be happy to merge this.
A simple integration test that uses the new licenses would also be nice.
I've already looked at the ci/circleci build output, and it fails because of :
From my understanding, we may not run ci/circleci tests if we're updating the yarn.lock file since it's running with the frozen-lockfile option. |
Don't think I understand what you mean. Can you elaborate? The issue is (the reason why CI fails) the entry in |
b9eab19
to
af2a089
Compare
|
fdc0dde
to
289eb66
Compare
Could you re-run the test-macos-node6/8 tests that were canceled ? |
Nevermind, I've force pushed to retrigger it. All checks have passed. Could you merge this please ? |
Summary
Updating validate-npm-package-license in order to update its dependencies :
This is allowing us to use newer licences such as EUPL-1.2.
kemitchell/validate-npm-package-license.js@v3.0.1...v3.0.3
jslicense/spdx-correct.js@v1.0.2...v3.0.0
jslicense/spdx-license-ids@v1.2.2...v3.0.0