Don't compute integrity when network restricted #6248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that git repositories have no integrity in the lockfile. This causes issues with
--offline
, since the current try will try to regenerate it (even if it won't succeed), and crash because it cannot access the network.There's two issues there:
Git repositories have no integrity. Even if we allow it, it should be marked in the lockfile (for example by setting
null
), in order to let Yarn know that the integrity couldn't be computed at all.When working with
--offline
, we shouldn't try to generate the integrity if it doesn't exist. This is what this PR fixes.cc @imsnif who worked on the integrity field.