Move information about using system libclang #1565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest to move the information about how to use system libclang before the cmake example line. As a new user I actually run the cmake command with PATH_TO_LLVM_ROOT=/ before reading the information about system libclang. I think place this information before the cmake example is more relevant for new users.
|
You also need to move the paragraph below it; the one that says that you shouldn't be using the system libclang. |
|
No response from author; closing (we can reopen later if needed). |
puremourning
added a commit
to puremourning/YouCompleteMe
that referenced
this pull request
Apr 29, 2021
eaea7553 Merge pull request ycm-core#1557 from bstaletic/conditional-absl b69b980d Merge pull request ycm-core#1565 from magras/fix-double-find-executable-call a12b2014 Merge pull request ycm-core#1564 from puremourning/quiet-build-single-line 2fb2038e Merge pull request ycm-core#1559 from AP2008/try-submodule-update b7986d4d Merge pull request ycm-core#1555 from bstaletic/log-trim ef2cab84 Merge pull request ycm-core#1556 from AP2008/add-msys-support d9f84560 Merge pull request ycm-core#1553 from bstaletic/rust-analyzer-borked a33969b0 Merge pull request ycm-core#1554 from bstaletic/sig-help-offset-fix
puremourning
added a commit
to puremourning/YouCompleteMe
that referenced
this pull request
May 1, 2021
In latest-first-order: 45f89b336 Merge pull request ycm-core#1566 from bstaletic/msvc-warnings 94999c6b0 Revert "Merge pull request ycm-core#1559 from AP2008/try-submodule-update" eaea7553 Merge pull request ycm-core#1557 from bstaletic/conditional-absl b69b980d Merge pull request ycm-core#1565 from magras/fix-double-find-executable-call a12b2014 Merge pull request ycm-core#1564 from puremourning/quiet-build-single-line 2fb2038e Merge pull request ycm-core#1559 from AP2008/try-submodule-update b7986d4d Merge pull request ycm-core#1555 from bstaletic/log-trim ef2cab84 Merge pull request ycm-core#1556 from AP2008/add-msys-support d9f84560 Merge pull request ycm-core#1553 from bstaletic/rust-analyzer-borked a33969b0 Merge pull request ycm-core#1554 from bstaletic/sig-help-offset-fix
puremourning
added a commit
to puremourning/YouCompleteMe
that referenced
this pull request
May 1, 2021
In latest-first-order: 45f89b336 Merge pull request ycm-core#1566 from bstaletic/msvc-warnings 94999c6b0 Revert "Merge pull request ycm-core#1559 from AP2008/try-submodule-update" eaea7553 Merge pull request ycm-core#1557 from bstaletic/conditional-absl b69b980d Merge pull request ycm-core#1565 from magras/fix-double-find-executable-call a12b2014 Merge pull request ycm-core#1564 from puremourning/quiet-build-single-line 2fb2038e Merge pull request ycm-core#1559 from AP2008/try-submodule-update b7986d4d Merge pull request ycm-core#1555 from bstaletic/log-trim ef2cab84 Merge pull request ycm-core#1556 from AP2008/add-msys-support d9f84560 Merge pull request ycm-core#1553 from bstaletic/rust-analyzer-borked a33969b0 Merge pull request ycm-core#1554 from bstaletic/sig-help-offset-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to move the information about how to use system libclang before the cmake example line. As a new user I actually run the cmake command with PATH_TO_LLVM_ROOT=/ before reading the information about system libclang.
I think place this information before the cmake example is more relevant for new users.
I did sign Google CLA