Use objc triggers for objcpp #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
Looks good! @zzbot r=micbou |
|
📌 Commit eb2072c has been approved by |
zzbot
added a commit
that referenced
this pull request
Oct 26, 2017
Use objc triggers for objcpp The objc triggers are perfectly valid in objcpp, so use them <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/865) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
Codecov Report
@@ Coverage Diff @@
## master #865 +/- ##
==========================================
+ Coverage 94.76% 94.77% +<.01%
==========================================
Files 79 79
Lines 5427 5435 +8
Branches 171 171
==========================================
+ Hits 5143 5151 +8
Misses 235 235
Partials 49 49 |
zzbot
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
Dec 3, 2017
[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#856: update JediHTTP; - PR ycm-core/ycmd#860: improve diagnostics location in C-family languages; - PR ycm-core/ycmd#865: use Objective-C triggers for Objective-C++; - PR ycm-core/ycmd#869: support TypeScript 2.6.1; - PR ycm-core/ycmd#875: allow switching to a different JavaScript project with `RestartServer`; - PR ycm-core/ycmd#877: support `-idirafter` include flag in C-family languages. Update the JavaScript documentation on how to switch to a different project. We only mention the `:YcmCompleter RestartServer` way as other methods involve restarting ycmd and losing all its data like stored identifiers. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2839) <!-- Reviewable:end -->
snakeleon
added a commit
to snakeleon/YouCompleteMe-x64
that referenced
this pull request
Dec 4, 2017
Include the following changes: - PR ycm-core/ycmd#856: update JediHTTP; - PR ycm-core/ycmd#860: improve diagnostics location in C-family languages; - PR ycm-core/ycmd#865: use Objective-C triggers for Objective-C++; - PR ycm-core/ycmd#869: support TypeScript 2.6.1; - PR ycm-core/ycmd#875: allow switching to a different JavaScript project with `RestartServer`; - PR ycm-core/ycmd#877: support `-idirafter` include flag in C-family languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objc triggers are perfectly valid in objcpp, so use them
This change is