[READY] Run 7-Zip in non-interactive mode #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbou
changed the title
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
micbou
force-pushed
the
no-7zip-prompt
branch
from
668d24d to
bfaf040
Compare
Add -y switch to 7-Zip command when extracting libclang from the installer.
micbou
force-pushed
the
no-7zip-prompt
branch
from
bfaf040 to
15d238e
Compare
micbou
changed the title
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
======================================
Coverage 94.7% 94.7%
======================================
Files 79 79
Lines 5440 5440
Branches 171 171
======================================
Hits 5152 5152
Misses 239 239
Partials 49 49 |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
📌 Commit 15d238e has been approved by |
zzbot
added a commit
that referenced
this pull request
Nov 5, 2017
[READY] Run 7-Zip in non-interactive mode When doing an incremental build on Windows, CMake will be stuck extracting libclang from the installer because 7-Zip asks the user if he want to overwrite existing files. We can avoid that by adding the `-y` option to the 7-Zip command. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/870) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing an incremental build on Windows, CMake will be stuck extracting libclang from the installer because 7-Zip asks the user if he want to overwrite existing files. We can avoid that by adding the
-yoption to the 7-Zip command.This change is