Add New GitHub Action for SLO Tests Integration with SDK #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polRk
changed the title
polRk
force-pushed
the
migrate-to-new-slo-action
branch
5 times, most recently
from
c05da0f
to
fc824ef
Compare
polRk
force-pushed
the
migrate-to-new-slo-action
branch
8 times, most recently
from
df153bd
to
a6d71a8
Compare
polRk
force-pushed
the
migrate-to-new-slo-action
branch
3 times, most recently
from
38389ac
to
2d51022
Compare
polRk
force-pushed
the
migrate-to-new-slo-action
branch
2 times, most recently
from
93891ea
to
280b32c
Compare
polRk
force-pushed
the
migrate-to-new-slo-action
branch
from
280b32c
to
60f284f
Compare
vgvoleg
reviewed
Nov 25, 2024
vgvoleg
reviewed
Nov 25, 2024
| @@ -121,7 +121,6 @@ def run_from_args(args): | |||
| driver_config = ydb.DriverConfig( | |||
| args.endpoint, | |||
| database=args.db, | |||
| credentials=ydb.credentials_from_env_variables(), | |||
There was a problem hiding this comment.
why have you deleted this? previous SLO was also with anonymous credentials
There was a problem hiding this comment.
Everything was fine with previous SLO.
Probably there's something wrong with new YDB cluster? It is not good to hide the issue
There was a problem hiding this comment.
Why I need to pass optional credentials parameter??
polRk
force-pushed
the
migrate-to-new-slo-action
branch
from
c544f3b
to
11c24a9
Compare
polRk
force-pushed
the
migrate-to-new-slo-action
branch
from
11c24a9
to
79aab75
Compare
vgvoleg
requested changes
Nov 26, 2024
| @@ -121,7 +121,6 @@ def run_from_args(args): | |||
| driver_config = ydb.DriverConfig( | |||
| args.endpoint, | |||
| database=args.db, | |||
| credentials=ydb.credentials_from_env_variables(), | |||
There was a problem hiding this comment.
Everything was fine with previous SLO.
Probably there's something wrong with new YDB cluster? It is not good to hide the issue
vgvoleg
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information