Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement separate snapshot output resolution for x- and y-dimensions #48

Closed
martijnende opened this issue Jul 12, 2020 · 0 comments · Fixed by #43
Closed

Implement separate snapshot output resolution for x- and y-dimensions #48

martijnende opened this issue Jul 12, 2020 · 0 comments · Fixed by #43
Assignees
Labels
feature Contributions related to new features
Milestone

Comments

@martijnende
Copy link
Collaborator

The spatial resolution of the snapshot output (OX) is controlled by NXOUT, but this only applies to the x-coordinate. The output resolution in the y-direction is the mesh resolution. It would be better to also have a NYOUT. Then, instead of:

do ixout=1, nn, pb%ox%nxout
    ...

one should have:

do ixout=1, nx, pb%ox%nxout
    do iyout=1, ny, pb%ox%nyout
        nout = (ixout - 1) * ny + iyout
        ...

in the OX module of output.f90 (currently being revised in #43)

@martijnende martijnende added the feature Contributions related to new features label Jul 12, 2020
@martijnende martijnende self-assigned this Jul 12, 2020
@martijnende martijnende added this to the 2.3.0 milestone Jul 12, 2020
@martijnende martijnende linked a pull request Jul 12, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Contributions related to new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant