fix: use crypto swap registry if available #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gauge isn't currently being provided by the curve crypto swap registry.. Have let them know and waiting for a response |
mariuspod
approved these changes
Dec 30, 2021
There was a problem hiding this comment.
I've tested this locally and it returns now the correct prices:
>>> curve.get_price("0x3D229E1B4faab62F621eF2F6A610961f7BD7b23B", 13907523)
2.129874676823631
>>> curve.get_price("0x3D229E1B4faab62F621eF2F6A610961f7BD7b23B", 13907516)
2.129874676823631
>>> curve.get_price("0x3b6831c0077a1e44ed0a21841c3bc4dc11bce833", 13907523)
2.1665122547780067
>>> curve.get_price("0x3b6831c0077a1e44ed0a21841c3bc4dc11bce833", 13907516)
2.1665122547780067
@jstashh Is this a blocker for this merge ? |
No, this should be fine to merge now, the incorrect gauge behavior is present in the current code so we're not introducing a regression |
mariuspod
pushed a commit
that referenced
this pull request
Jan 17, 2022
* fix: use crypto swap registry if available * fix: make boolean check more explicit
mariuspod
pushed a commit
to BobTheBuidler/yearn-exporter
that referenced
this pull request
Jan 27, 2022
* fix: use crypto swap registry if available * fix: make boolean check more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187
Check to see if the 'CryptoSwap' registry can be used before falling back to the original registry
The crypto swap registry can be found at position 5 in the address provider