[WEB-1247-199] Refactor price magic and set TVL of ib to 0 after 2022-01-22 #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yearn-linear-gh-sync
bot
changed the title
WEB-1247 [WEB-1247-199] Refactor price magic and set TVL of ib to 0 after 2022-01-22
Compared TVLs for ETH and FTM at e1c2867, they matched exactly to the numbers before the refactoring at a specific block: With the ironbank tvl change 7c4a75b this might be harder to verify, I can also move the ib fix into a separate PR if that's preferred. |
banteg
requested changes
Jan 25, 2022
yearn/ironbank.py
Outdated
| if block_ts > snapshot_ts: | ||
| tvl = 0 | ||
| else: | ||
| tvl = (res["getCash"] + res["totalBorrows"] - res["totalReserves"]) * price |
There was a problem hiding this comment.
need to clarify the formula, see #201
| synthetix, | ||
| band, | ||
| uniswap_v2, | ||
| uniswap_v3, |
There was a problem hiding this comment.
maybe it's time we switch to trying uni v3 before v2? need to check it doesn't break historical exporter.
There was a problem hiding this comment.
didn't check that one yet
banteg
requested changes
Jan 26, 2022
…aunched as a separate product.
…d use that for comparing with the current block.
…uded after the snapshot block.
…e function so it can be cached.
…rn-lens more explicit again.
mariuspod
force-pushed
the
feat/price_magic_ib_tvl
branch
from
914a627 to
092ce07
Compare
* fix: ironbank dash * fix: overview dash * update overview changes * update TVL in Yearn Ecosystem dash * update vault overview dash * run prettier
banteg
approved these changes
Jan 27, 2022
mariuspod
added a commit
to BobTheBuidler/yearn-exporter
that referenced
this pull request
Jan 27, 2022
…-01-22 (yearn#199) * fix: added ust stablecoin. * feat: refactor multiple chain-based #get_price methods into a single one. * feat: set ironbank tvl to 0 after 2022-01-22T00:00:00Z because they launched as a separate product. * fix: define a constant for the ironbank snapshot block per network and use that for comparing with the current block. * fix: allow to override the default behaviour where the ib TVL is excluded after the snapshot block. * fix: remove __repr__ method. * fix: remove chain.id check. * fix: make token unwrapping chain-aware. * feat: refactor balance as a class. Move memory-cached code into a pure function so it can be cached. * feat: refactor pool-like markets and add #is_in_pool and #get_pool_price for them * fix: make the usage of the constant more explicit. * fix: remove special handling here to not obscure any underlying problems. * fix: order for if-check * fix: change market order. * fix: create two metrics to track ib tvl before and after the snapshot. * fix: revert changes and make querying of uniswap_v2, balancer and yearn-lens more explicit again. * fix: oracles could be empty for the given network. * feat: remove ib tvl from the total sums if the conditions are met. * fix: constant import * fix: remove unused __repr__ methods. * fix: resolve circular import for balancer. * Update dashboards (yearn#209) * fix: ironbank dash * fix: overview dash * update overview changes * update TVL in Yearn Ecosystem dash * update vault overview dash * run prettier Co-authored-by: Dark Ghosty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared TVLs for ETH and FTM at e1c2867, they matched exactly to the numbers before the refactoring at a specific block:
With the ironbank tvl change 7c4a75b this might be harder to verify, I can also move the ib fix into a separate PR if that's preferred.