Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1253-200] fix: arbitrum fixes #200

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Conversation

jstashh
Copy link
Contributor

@jstashh jstashh commented Jan 24, 2022

No description provided.

@yearn-linear-gh-sync yearn-linear-gh-sync bot changed the title fix: arbitrum fixes [WEB-1253-200] fix: arbitrum fixes Jan 24, 2022
Copy link
Member

@banteg banteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than the comment

@@ -63,7 +63,7 @@ def get_price(self, token, block=None):

paths += [[token, fee, usdc] for fee in self.fee_tiers]

scale = 10 ** contract(token).decimals()
scale = 10 ** interface.ERC20(token).decimals()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid interfaces before this is fixed eth-brownie/brownie#1092

@banteg banteg merged commit ed557ac into yearn:master Jan 26, 2022
mariuspod pushed a commit to BobTheBuidler/yearn-exporter that referenced this pull request Jan 27, 2022
* fix: arbitrum pricing fixes, disable curve apy for now

* fix: revert change to interface

* fix: remove unused interface import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants