[WEB-1259-203] fix: correct calculation of discounted rKP3R price #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yearn-linear-gh-sync
bot
changed the title
banteg
approved these changes
Jan 25, 2022
mariuspod
pushed a commit
to BobTheBuidler/yearn-exporter
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calculating rKP3R discount incorrectly. Instead of using the
rKP3R.discount()as the percentage that rKP3R discounted KP3R redemption price, we should actually be using100 - rKP3R.discount(), since thediscountrepresents the percentage of the real price that strike price is. At 50%, this didn't matter, so it was correct either way, but on the shift to 90%, it became incorrect.In the past, CVX and CRV made up the vast majority of the APR for these vaults, so it wasn't clear that something was wrong. But with KP3R's recent moon and CVX and CRV crashing, the difference became noticeable.