Modernize github workflows #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit f2652ad): https://yew-rs-api--pr3711-github-dl-artifacts-ugq27tvs.web.app (expires Thu, 29 Aug 2024 00:48:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
this mainly fixes some inconsistencies in style, outdated or wrong comments and action version - replace Legit-Labs/action-download-artifact with actions/download-artifact - fix Swatinem/rust-cache arguments - fix benchmark transformations - expand feature soundness lints - wording and capitalization in comments
WorldSEnder
force-pushed
the
github-dl-artifacts-v4
branch
from
02d7473 to
95337a6
Compare
ranile
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This mainly fixes some inconsistencies in style, outdated or wrong comments and action versions
shared-keyto group things into only a few categories. Note that environment flags will still lead to different caches being used.cargo hackAll in all, it looks a bit messy, but this is supposed to take care of quite a bit of cruft.
Checklist