Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(NavbarItem): improve readability and maintainability #3763

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brilliantkid87
Copy link

@brilliantkid87 brilliantkid87 commented Nov 6, 2024

Description

  1. Regex and Version Extraction: Updated useVersion hook with a descriptive regex constant (VERSION_REGEX) to extract the version from the URL.
  2. API URL Handling: Created a helper function, getApiUrl, to dynamically determine the API URL based on the extracted version. This replaces inline logic for API URL generation.
  3. Constants: Moved API base URLs to a centralized constant (API_BASE_URLS) for cleaner and more flexible URL management.
  • I have reviewed my own code
  • I have added tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant