Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Search support #894

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Voice Search support #894

merged 4 commits into from
Aug 2, 2021

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Jul 23, 2021

Add support for voice search

This includes updating the styling of the icons and adding the default config

J=SLAP-1444
TEST=manual

Point the test site to the SDK with voice search and see the icon appear and work correctly. Test adding custom icons and confirm the styling looks good

@coveralls
Copy link

coveralls commented Jul 23, 2021

Coverage Status

Coverage remained the same at 6.43% when pulling 893ab80 on dev/voice-search into 31a5c36 on develop.

@cea2aj cea2aj requested review from oshi97 and yen-tt August 2, 2021 18:57
@cea2aj cea2aj merged commit 48094d7 into develop Aug 2, 2021
@cea2aj cea2aj deleted the dev/voice-search branch August 2, 2021 20:08
@cea2aj cea2aj mentioned this pull request Aug 24, 2021
cea2aj added a commit that referenced this pull request Aug 24, 2021
### Features
- Support for new languages including Chinese (Traditional), Chinese (Simplified), Russian, Polish, Portuguese, Dutch, Arabic, Korean, Swedish, and Hindi (#918) (#900)
- A loading indicator can now be enabled on the search bar (#875)
- Voice search support (#894)
- Analytics, session tracking, and query source can now be toggled through Runtime Config (#869) (#879)
- Added validation to ensure that parts of global_config and page configs are valid (#888)
- Font preloads are now located in the layouts/preload-fonts.hbs file (#893)
- Global config now includes "sessionTrackingEnabled" and "analyticsEventsEnabled" (#898)
- Added a partial for additional Answers configuration (#903)
- Map pins now support custom label colors (#922)

### Enhancements
- The full-page-map "Search This Area" functionality is better optimized when a user quickly zooms in or out of the map (#861)
- Improved build time during development mode (#865)
- Icons were updated from components to Handlebars partials to improve performance (#874)

### Bugfixes
- When upgrading the theme version, the global config will no longer contain duplicate options which are commented out (#916)
- When upgrading the theme, the tests folders are now removed which improves build performance (#913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants