Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat-headless: remove session storage support in favor of local storage #49

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

popestr
Copy link
Collaborator

@popestr popestr commented Jun 3, 2024

Removes all references and usages of session storage in favor of local storage. This means that conversation state will now persist across pages as well as refreshes, so long as all pages are on the same hostname.

TEST=manual,auto

Updated unit tests, saw them pass. Ran local test page and refreshed, closed tabs, reopened. State persisted always.

Removes all references and usages of session storage in favor
of local storage. This means that conversation state will now persist
across pages as well as refreshes, so long as all pages are on the
same hostname.

TEST=manual,auto

Updated unit tests, saw them pass. Ran local test page and refreshed,
closed tabs, reopened. State persisted always.
@popestr popestr requested a review from a team as a code owner June 3, 2024 19:50
@yen-tt yen-tt merged commit 0b2f4e9 into main Jun 5, 2024
8 checks passed
@yen-tt yen-tt deleted the swap-local-storage-for-session-storage branch June 5, 2024 19:49
yen-tt added a commit that referenced this pull request Jun 5, 2024
updates following this breaking change in headless: #49

J=CLIP-1292
TEST=auto&manual

see that unit tests passed. spun up test site and see that convo state persist across tabs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants