-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pages-components): schema type validation #75
Conversation
|
I think we return nothing if the object isn't what we expect. Confirm with @apav-dev. |
As far as I can tell, faq is the only place where a bad input type would cause an error as opposed to just returning undefined/empty data.
@mkilpatrick Do we want to throw errors or print warnings in other places?
For example:
If there is no
c_aggregateRating
field on the document,aggregateRating
won't appear in the returned schema.If
c_aggregateRating
is on the document but is a Number instead of an Object, Product will return undefined values