Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Answers -> Search 1: Customer facing renaming #141

Merged
merged 16 commits into from
Jul 14, 2022
Merged

Answers -> Search 1: Customer facing renaming #141

merged 16 commits into from
Jul 14, 2022

Conversation

ElemelonWind
Copy link
Contributor

@ElemelonWind ElemelonWind commented Jul 1, 2022 •
edited
Loading

Renamed all customer-facing components. Pt. 2 will be updating the imports from search-core and search-headless.

J=SLAP-2196
TEST=auto

@coveralls
Copy link

coveralls commented Jul 1, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 79.612% when pulling 80b0b36 on renaming-edits into 88e48dd on feature/answers-to-search.

@ElemelonWind ElemelonWind marked this pull request as ready for review July 5, 2022 13:55
@ElemelonWind ElemelonWind requested a review from a team as a code owner July 5, 2022 13:55
oshi97
oshi97 reviewed Jul 5, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@oshi97
Copy link
Contributor

oshi97 commented Jul 5, 2022 •
edited
Loading

the blank deprecation.test.tsx is causing the tests to fail!

@ElemelonWind ElemelonWind marked this pull request as draft July 6, 2022 13:25
@ElemelonWind ElemelonWind changed the title Renaming Edits for Answers -> Search Answers -> Search 1: Customer facing renaming Jul 11, 2022
@ElemelonWind ElemelonWind changed the base branch from main to feature/answers-to-search July 12, 2022 16:02
@ElemelonWind ElemelonWind changed the title Answers -> Search 1: Customer facing renaming Answers -> Search 2: Customer facing renaming Jul 12, 2022
@ElemelonWind ElemelonWind changed the title Answers -> Search 2: Customer facing renaming Answers -> Search 1: Customer facing renaming Jul 12, 2022
@ElemelonWind ElemelonWind marked this pull request as ready for review July 12, 2022 18:04
yen-tt
yen-tt reviewed Jul 12, 2022
View reviewed changes
src/deprecated.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
yen-tt
yen-tt reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@yen-tt yen-tt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update a couple more things that user would look at/interact with in this PR as well?

  • README file
  • the path in tsconfig.base.json
  • docs in subscribeToStateUpdates
  • the error messages in useSearchActions

package.json Outdated
"version": "1.2.0",
"description": "The official React UI Bindings layer for Answers Headless",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets update the description to Search Headless

yen-tt
yen-tt reviewed Jul 13, 2022
View reviewed changes
README.md Outdated
}
}

export default subscribeToStateUpdates(state => ({
Copy link
Contributor

@yen-tt yen-tt Jul 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want the updated README portion here from develop, I think you might have reverted back when resolving merge conflict (subscribeToStateUpdates is now deprecated)

@oshi97
Copy link
Contributor

oshi97 commented Jul 13, 2022

Could we rebase the feature branch with develop?

@ElemelonWind
Copy link
Contributor Author

Could we rebase the feature branch with develop?

Am I able to do that without committing to it yet? When I try it just says "there isn't anything to compare"

@yen-tt
Copy link
Contributor

yen-tt commented Jul 14, 2022

Could we rebase the feature branch with develop?

Am I able to do that without committing to it yet? When I try it just says "there isn't anything to compare"

you may be rebasing this branch (which you already merge with develop) instead of feature/answers-to-search. You can switch to the feature branch rebase in the terminal or make a pull request with base point to feature/answers-to-search and compare point to develop if you want.

@ElemelonWind ElemelonWind merged commit e0b5013 into feature/answers-to-search Jul 14, 2022
@ElemelonWind ElemelonWind deleted the renaming-edits branch July 14, 2022 20:17
ElemelonWind added a commit that referenced this pull request Jul 19, 2022
@ElemelonWind @github-actions
Answers -> Search (#143)
0ac8701 
* Answers -> Search 1: Customer facing renaming (#141)

* Update README.md

* README and package updates

* prelim renaming

* Deprecation tag and exports updates

* public deprecation message

* Deprecation fix

* Update index.ts

* Delete deprecation.test.tsx

* deprecated file

* fix lint issues

* more updates

* test fixes

* readme fix

* fix types exports

* Answers -> Search 2: rename imports (#144)

* renamed answers-headless imports

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

* version update

* update license

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* rebase w develop

* fix typos

* addressed nits

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yen-tt yen-tt yen-tt left review comments

@oshi97 oshi97 oshi97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElemelonWind @coveralls @oshi97 @yen-tt