Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PagesJS compatibility #190

Merged
merged 9 commits into from
Sep 29, 2023
Merged

PagesJS compatibility #190

merged 9 commits into from
Sep 29, 2023

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Sep 25, 2023

Introduce tsup and improve the package.json file in order to support PagesJS.

This works in both dev and prod mode of pagesJS

J=BACK-2545
TEST=manual

Publish an alpha version and test it with yext/search-ui-react#400 and @yext/[email protected]. Add several search components to the page and confirm they work as expected.

@cea2aj cea2aj requested a review from a team as a code owner September 25, 2023 22:47
@cea2aj cea2aj changed the title Dev/add tsup PagesJS compatibility Sep 25, 2023
@coveralls
Copy link

coveralls commented Sep 26, 2023

Coverage Status

coverage: 94.34% (+0.1%) from 94.231% when pulling ccac76d on dev/add-tsup into 99c3358 on release/v2.4.0.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@benmcginnis
Copy link
Member

benmcginnis commented Sep 28, 2023 via email

@cea2aj cea2aj merged commit 3b8f863 into release/v2.4.0 Sep 29, 2023
10 of 14 checks passed
@cea2aj cea2aj deleted the dev/add-tsup branch September 29, 2023 17:35
@nmanu1 nmanu1 mentioned this pull request Dec 8, 2023
nmanu1 added a commit that referenced this pull request Dec 8, 2023
### Changes
- Added support for document verticals (#191)
- Added compatibility with PagesJS v1 (#190)
### Fixes
- Upgraded `@babel/traverse` version to address a vulnerability in the package (#194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants