-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PagesJS compatibility #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cea2aj
force-pushed
the
dev/add-tsup
branch
from
September 26, 2023 15:20
65fe968
to
8c446c9
Compare
mkilpatrick
reviewed
Sep 27, 2023
We’d have to do a breaking change right? In case people are using the other
ways
…On Thu, Sep 28, 2023 at 10:55 AM cea2aj ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In package.json
<#190 (comment)>
:
> "src",
"THIRD-PARTY-NOTICES"
],
"scripts": {
- "build": "rm -rf lib/** && npm run build:esm && npm run build:cjs && npm run generate-notices",
- "build:esm": "tsc -p tsconfig.esm.json",
- "build:cjs": "tsc -p tsconfig.cjs.json",
+ "build": "rm -rf lib/** && rm -rf dist/** && npm run build:js && npm run generate-notices",
+ "build:js": "tsc -p tsconfig.esm.json && tsc -p tsconfig.cjs.json && tsup src/index.ts --dts --sourcemap --format esm,cjs",
yes, that means the it's being built 4 times. If we want to remove two of
those, I can remove tsc and copy the build output from dist to lib, or I
could add additional package.json files in lib in order to redirect those
imports to dist
—
Reply to this email directly, view it on GitHub
<#190 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJGVKOCQIQTVIPD4NPF36LX4WFWDANCNFSM6AAAAAA5GZKIV4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
benmcginnis
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce tsup and improve the package.json file in order to support PagesJS.
This works in both dev and prod mode of pagesJS
J=BACK-2545
TEST=manual
Publish an alpha version and test it with yext/search-ui-react#400 and @yext/[email protected]. Add several search components to the page and confirm they work as expected.