Fix issue where electron doesn't open with electron:dev task #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"react-scripts start" launches a dev server on IPv4. With Node 17+ on Windows, "wait-on http://localhost:3000" tries to connect over IPv6 and fails. By changing the command to "wait-on http://127.0.0.1:3000", wait-on will make an IPv4 request and succeed, allowing electron to open. Here's a related thread about other people running into this issue: jeffbski/wait-on#109
|
Thanks a lot! |
|
The solution worked on node v18. Thank you very much for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows (probably other systems too) with Node 17+, running
yarn electron:devfails to open electron. This happens because the "wait-on http://localhost:3000" step of the script never succeeds.react-scripts startlaunches a dev server on IPv4 (because https://github.com/facebook/create-react-app/blob/d960b9e38c062584ff6cfb1a70e1512509a966e7/packages/react-scripts/scripts/start.js#L56 specifies that it listens on "0.0.0.0", an IPv4 address).wait-on http://localhost:3000tries to connect over IPv6 and fails. By changing the command towait-on http://127.0.0.1:3000, wait-on will make an IPv4 request and succeed, allowing electron to open.Here's a related thread about other people running into this issue with wait-on and working around it similarly: jeffbski/wait-on#109