using v5 of oz contracts #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan13ram
force-pushed
the
fix/update-openzeppelin
branch
from
3d9809e to
4d1ac29
Compare
dan13ram
commented
Jan 29, 2025
| @@ -3,11 +3,18 @@ | |||
| url = https://github.com/foundry-rs/forge-std | |||
| [submodule "lib/LayerZero-v2"] | |||
| path = lib/LayerZero-v2 | |||
| url = https://github.com/JorgeAtPaladin/LayerZero-v2 | |||
| branch = lz-upgrade | |||
| url = https://github.com/dan13ram/layerzero-v2-upgradeable | |||
There was a problem hiding this comment.
Uses my fork of this repo
https://github.com/dan13ram/layerzero-v2-upgradeable
Which is one commit ahead, diff below:
JorgeAtPaladin/LayerZero-v2@lz-upgrade...dan13ram:layerzero-v2-upgradeable:main
dan13ram
commented
Jan 29, 2025
| @@ -7,10 +7,6 @@ | |||
| "@layerzerolabs/lz-evm-oapp-v2": "^2.1.18", | |||
| "@layerzerolabs/lz-evm-protocol-v2": "^2.1.27", | |||
| "@layerzerolabs/lz-evm-v1-0.7": "^2.3.40", | |||
| "@openzeppelin/contracts": "5.0.2", | |||
There was a problem hiding this comment.
moves all openzeppelin deps to submodule
dan13ram
commented
Jan 29, 2025
| @@ -1,8 +1,8 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity ^0.8.24; | |||
|
|
|||
| import "src/external/AccessControlUpgradeable.sol"; | |||
| import "src/external/ERC20Upgradeable.sol"; | |||
| import {AccessControlUpgradeable} from "@openzeppelin/contracts-upgradeable/access/AccessControlUpgradeable.sol"; | |||
There was a problem hiding this comment.
removes the need for oz contracts inside our repo
dan13ram
force-pushed
the
fix/update-openzeppelin
branch
3 times, most recently
from
2372c37 to
f0f2d15
Compare
dan13ram
force-pushed
the
fix/update-openzeppelin
branch
from
f0f2d15 to
485bb97
Compare
|
i don't know why this is done, closing, there's no justification for this, and it's a wide scope change with no audits Furthermore i don't know how this fork is acceptable to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.