Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on evaluate 1.0.3 work.
knitr does entrace all error with rlang when available. This is done now in the calling handler of evaluate, closest to the error being thrown
evaluate does handle already trimming the backtrace for error thrown in the code evaluated. knitr need also to do it for error happening in its
value
handler passed to evaluate, and callingknit_print()
knit_print()
level directly; But it could be done also at the value handlerknitr/R/utils.R
Lines 882 to 887 in 8a37857