Refactoring Carousel widget.
#174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
terabytesoftw
commented
Nov 6, 2024
terabytesoftw
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
vjik
requested changes
Nov 8, 2024
…t types and improve caption handling.
…dling and improve attribute management.
samdark
requested changes
Nov 11, 2024
vjik
requested changes
Nov 12, 2024
samdark
approved these changes
Nov 12, 2024
Comment on lines
+514
to
518
| $activeItems = array_filter($this->items, static fn (CarouselItem $item) => $item->isActive()); | ||
|
|
||
| if (count($activeItems) > 1) { | ||
| throw new InvalidArgumentException('Only one carousel item can be active at a time.'); | ||
| } |
There was a problem hiding this comment.
This check could be done inside of foreach.
There was a problem hiding this comment.
I thought about it too, but i need to know before iterating if any element is active, otherwise i mark the first one as active, and there may be the possibility that any element is active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.