Skip to content

Commit

Permalink
Fix flaky CertNetFetcherURLLoaderTest
Browse files Browse the repository at this point in the history
The ReconnectsAfterURLLoaderFactoryDisconnection test checks that
there have been at most two requests after the URLLoaderFactory
disconnects and reconnects, but it should have been checking for
at least two requests.

Bug: 1168193
Change-Id: I7c816e433a10e043e70dc1032519b8795253dd3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641141
Commit-Queue: Ryan Sleevi <[email protected]>
Auto-Submit: Matthew Denton <[email protected]>
Reviewed-by: Ryan Sleevi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#845671}
  • Loading branch information
mdenton8 authored and Chromium LUCI CQ committed Jan 21, 2021
1 parent 98126cf commit 2c9475f
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ TEST_F(CertNetFetcherURLLoaderTest,
request1->WaitForResult(&error, &body);
}

EXPECT_GE(2, NumCreatedRequests());
EXPECT_LE(2, NumCreatedRequests());

ResetTestURLLoaderFactory();

Expand Down

0 comments on commit 2c9475f

Please sign in to comment.