Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility bug: everything is a tooltip except modal dialogs #334

Open
adamnovak opened this issue Mar 28, 2023 · 0 comments
Open

Accessibility bug: everything is a tooltip except modal dialogs #334

adamnovak opened this issue Mar 28, 2023 · 0 comments

Comments

@adamnovak
Copy link

Aria tooltips are only allowed to be used for actual tooltips. It would be a bug to use that role for anything other than contextual help, such as a context menu or a popup with controls in it.

But here the role of popups is hardcoded to be either "dialog" for modal dialogs, or "tooltip" for anything that isn't a modal dialog:

role={isModal ? 'dialog' : 'tooltip'}

This makes the library not work for non-modal dialogs, or for menus, because they would have the incorrect tooltip role.

adamnovak added a commit to vgteam/sequenceTubeMap that referenced this issue Mar 28, 2023
This is the only way to get the correct role=dialog on it. Otherwise it
always has role=tooltip and we can't change it. See https://github.com/yjose/reactjs-popup/blob/4d8e41a5995ba5074c0133bf0901bf0f93805616/src/index.tsx#L280 and yjose/reactjs-popup#334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant